✨ Fake IDE/RPC Debugger Demo #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonahSussman
force-pushed
the
initial-rpc-server
branch
2 times, most recently
from
e0a2be2
to
958572d
Compare
JonahSussman
changed the title
JonahSussman
force-pushed
the
initial-rpc-server
branch
from
add155b
to
298cc0f
Compare
playpen/middleman/server.py
Outdated
| process_id: Optional[int] | ||
|
|
||
| root_uri: str | ||
| kantra_uri: str |
There was a problem hiding this comment.
We don't need kantra_uri anymore
shawn-hurley
requested changes
Oct 14, 2024
playpen/repo_level_awareness/agent/dependency_agent/dependency_agent.py
Outdated
Show resolved
Hide resolved
playpen/repo_level_awareness/agent/dependency_agent/dependency_agent.py
Outdated
Show resolved
Hide resolved
| @@ -43,13 +48,13 @@ def __eq__(self, o: object) -> bool: | |||
| return True | |||
| return False | |||
|
|
|||
| def __iter__(self) -> Iterator[str]: | |||
| return iter([v.to_dict() for _, v in self.items()]) | |||
| # def __iter__(self) -> Iterator[str]: | |||
There was a problem hiding this comment.
was this gross? I needed to convert nested objects that are a dict to a list instead as I didn't care about their keys
JonahSussman
force-pushed
the
initial-rpc-server
branch
from
a9ad526
to
a22de06
Compare
shawn-hurley
approved these changes
Oct 15, 2024
| MavenCompileStep(task_manager_config), | ||
| AnalyzerLSPStep(task_manager_config), | ||
| ], | ||
| agents=[ |
There was a problem hiding this comment.
We are going to want to add the dependency agents
note to selves, rename to task runners
| @@ -7,6 +7,12 @@ | |||
| @dataclass(eq=False, kw_only=True) | |||
| class AnalyzerRuleViolation(ValidationError): | |||
| incident: Incident | |||
|
|
|||
| # NOTE(JonahSussman): Violation contains a list of Incidents, and RuleSet | |||
There was a problem hiding this comment.
I am a plus one on this comment and doing it in a followup
| @@ -13,59 +13,66 @@ | |||
| from playpen.repo_level_awareness.task_runner.analyzer_lsp.api import ( | |||
| AnalyzerRuleViolation, | |||
| ) | |||
| from playpen.rpc.core import JsonRpcServer | |||
There was a problem hiding this comment.
Wow! thanks for updating this, I was planning on coming back to this but this is great!
Signed-off-by: JonahSussman <[email protected]>
Signed-off-by: JonahSussman <[email protected]>
Signed-off-by: JonahSussman <[email protected]>
Signed-off-by: JonahSussman <[email protected]>
Signed-off-by: JonahSussman <[email protected]>
Signed-off-by: JonahSussman <[email protected]>
Signed-off-by: JonahSussman <[email protected]>
Signed-off-by: JonahSussman <[email protected]>
Signed-off-by: JonahSussman <[email protected]>
Signed-off-by: JonahSussman <[email protected]>
Signed-off-by: JonahSussman <[email protected]>
Signed-off-by: JonahSussman <[email protected]>
Signed-off-by: JonahSussman <[email protected]>
Signed-off-by: JonahSussman <[email protected]>
Signed-off-by: JonahSussman <[email protected]>
Signed-off-by: JonahSussman <[email protected]>
JonahSussman
force-pushed
the
initial-rpc-server
branch
from
55999a8
to
aadc0e0
Compare
JonahSussman
merged commit c36aabc
into
konveyor:feature/repository-level-awareness
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit history looks ugly, I just need to rebase